PING? RFR(S): 8239785: Cgroups: Incorrect detection logic on old systems in hotspot

[Severin Gehwolf]

Hi Matthias,

On Thu, 2020-03-12 at 07:05 +0000, Baesken, Matthias wrote:
> Hello Severin, looks okay to me .

Thanks very much for the review!

> Some very minor issues (do not need  to see another webrev)  :
> 
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8239785/05/webrev/src/hotspot/share/prims/whitebox.cpp.frames.html
> 
> CHECK_JNI_EXCEPTION_
> might return early without calling  env->ReleaseStringUTFChars (these are in the normal cases called at the end of the method)
> 
> 
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8239785/05/webrev/src/hotspot/share/prims/whitebox.hpp.frames.html
> please adjust Copyright year
> 
> 
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8239785/05/webrev/src/hotspot/os/linux/cgroupSubsystem_linux.hpp.frames.html
> 
>  260 class CgroupInfo : public StackObj {
>   ....
>  274     CgroupInfo() { // constructor    <---- remove comment

OK. I'll make the suggested changes, retest and then push.

Thanks,
Severin

> 
> Best regards, Matthias
> 
> 
> 
> > I would still need a *R*eviewer for this one. Any takers? Bob has
> > already reviewed it.
> > 
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8239785/05/webrev/
> > 
> > Thanks,
> > Severin
> >