RFR: 8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic [v4]

[Andrew Haley]

On Tue, 3 Nov 2020 11:51:42 GMT, Dong Bo <dongbo at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5483:
>> 
>>> 5481:     Register codec  = rscratch1;
>>> 5482:     Register length = rscratch2;
>>> 5483: 
>> 
>> Alias names for scratch registers have proved to be risky because assembler macros use scratch registers freely. A maintenance programmer might not to see this code uses rscratch1 and 2. Given that c_rarg6 and 7 are free, please use them.
>
> Done, I didn't realize this would be a problem at all.
> Thanks for the clarification.

OK, thanks, I need to write some of this stuff down as guidance. Aliases for register names are always risky, but for the scratch registers doubly so.

-------------

PR: https://git.openjdk.java.net/jdk/pull/992