RFR: 8253742: POSIX signal code cleanup [v5]

[Gerard Ziemski]

On Tue, 10 Nov 2020 17:14:42 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>>> > > Forward declaration was a new concept to me, so I had to look it up and although it was easy enough to do it for the internal c++ classes, I struggled with the forward declaring of `struct sigset_t`, but I thought I found it.
>>> > > Should I also drop the forward declaration for `outputStream`, `Thread`, `OSThread`?
>>> > 
>>> > 
>>> > For hotspot classes, I would leave the forward declarations in and the headers out. Current standard practice. System headers OTOH I would either include here or, somewhat better, in globalDefinitions_gcc.hpp.
>>> 
>>> Ha! It is already in globalDefinitions_gcc.hpp so neither the direct
>>> include nor the forward declarations are actually needed.
>> 
>> Many thanks Thomas & David for the lesson on the header files!
>> 
>> If I understand it correctly, then we need to add `#include "utilities/globalDefinitions.hpp"` to signals_posix.hpp, correct?
>
>> > > > Forward declaration was a new concept to me, so I had to look it up and although it was easy enough to do it for the internal c++ classes, I struggled with the forward declaring of `struct sigset_t`, but I thought I found it.
>> > > > Should I also drop the forward declaration for `outputStream`, `Thread`, `OSThread`?
>> > > 
>> > > 
>> > > For hotspot classes, I would leave the forward declarations in and the headers out. Current standard practice. System headers OTOH I would either include here or, somewhat better, in globalDefinitions_gcc.hpp.
>> > 
>> > 
>> > Ha! It is already in globalDefinitions_gcc.hpp so neither the direct
>> > include nor the forward declarations are actually needed.
>> 
>> Many thanks Thomas & David for the lesson on the header files!
>> 
>> If I understand it correctly, then we need to add `#include "utilities/globalDefinitions.hpp"` to signals_posix.hpp, correct?
> 
> Yes.

> _Mailing list message from [David Holmes](mailto:david.holmes at oracle.com) on [hotspot-dev](mailto:hotspot-dev at openjdk.java.net):_
> 
> On 11/11/2020 3:04 am, Gerard Ziemski wrote:
> 
> > Many thanks Thomas & David for the lesson on the header files!
> > If I understand it correctly, then we need to add `#include "utilities/globalDefinitions.hpp"` to signals_posix.hpp, correct?
> 
> It is already there.
> 
> #ifndef OS_POSIX_SIGNALS_POSIX_HPP
> #define OS_POSIX_SIGNALS_POSIX_HPP
> 
> #include "memory/allocation.hpp"
> #include "utilities/globalDefinitions.hpp"
> 
> #include <signal.h>
> 
> So you can just delete the include of signal.h

`#include "memory/allocation.hpp"` has:

`#include "memory/allStatic.hpp"
#include "utilities/globalDefinitions.hpp"`

so in the end `"memory/allocation.hpp"` is all we need.

-------------

PR: https://git.openjdk.java.net/jdk/pull/636