RFR: 8253742: POSIX signal code cleanup [v5]

[David Holmes]

On 13/11/2020 6:16 am, Gerard Ziemski wrote:
>>> If I understand it correctly, then we need to add `#include "utilities/globalDefinitions.hpp"` to signals_posix.hpp, correct?
>>
>> It is already there.
>>
>> #ifndef OS_POSIX_SIGNALS_POSIX_HPP
>> #define OS_POSIX_SIGNALS_POSIX_HPP
>>
>> #include "memory/allocation.hpp"
>> #include "utilities/globalDefinitions.hpp"
>>
>> #include <signal.h>
>>
>> So you can just delete the include of signal.h
> 
> `#include "memory/allocation.hpp"` has:
> 
> `#include "memory/allStatic.hpp"
> #include "utilities/globalDefinitions.hpp"`
> 
> so in the end `"memory/allocation.hpp"` is all we need.

Yes but we don't like to rely on extreme levels of indirection as they 
are completely obscure. globalDefinitions.hpp is a known source of a 
whole bunch of includes (which a number of folk find objectionable in 
itself) so it is okay to get an indirect include through it.

In all seriousness I would just leave the existing includes alone. If it 
ain't broke ...  and this is wasting far too many cycles for everyone.

Thanks,
David
-----

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/636
>