RFR: 8256380: JDK-8254162 broke 32bit windows build
    David Holmes 
    dholmes at openjdk.java.net
       
    Tue Nov 17 02:01:05 UTC 2020
    
    
  
On Mon, 16 Nov 2020 12:13:38 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> Fix win-32 linker error due to forward declaration and definition signature mismatch.
> 
> FWIW, the altered header is included from nativeLookup.cpp, which uses the function pointer of that function. But, since the signature of the definition [1] is different, and due to name mangling on the particular ABI, the symbols of the declaration in the header and definition are different as well, and things fail to link later.
> 
> Testing: Building Windows-x86 locally, and running jdk_foreign tests.
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/prims/scopedMemoryAccess.cpp#L181
src/hotspot/share/prims/scopedMemoryAccess.hpp line 32:
> 30: 
> 31: extern "C" {
> 32:   void JNICALL JVM_RegisterJDKInternalMiscScopedMemoryAccessMethods(JNIEnv *env, jclass scopedMemoryAccessClass);
Why isn't this declared with JNIEXPORT like the functions in jvm.h?
-------------
PR: https://git.openjdk.java.net/jdk/pull/1222
    
    
More information about the hotspot-dev
mailing list