RFR: JDK-8256922: ppc, ppcle build broken after JDK-8254231 [v2]

Martin Doerr mdoerr at openjdk.java.net
Tue Nov 24 10:28:55 UTC 2020


On Tue, 24 Nov 2020 10:18:35 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Please don't use `_abi_reg_args_spill` because it's often used for `abi_minframe` and other derived structures, too.
>> We could name it `_ppc_abi` because it refers to the layout specified in the 64-bit PowerPC ELF Application Binary Interface.
>> But I'm also fine with with `_abi0`.
>
> @TheRealMDoerr Why not use `_abi_reg_args`, as Aleksey suggested? Do you see an issue with that name as well?

I think that would be confusing, because `_abi_reg_args` sounds like we had a `abi_reg_args` structure on stack which is often not the case. We are using it for any frame structure which is based on `abi_minframe`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1404


More information about the hotspot-dev mailing list