RFR: 8256382: Use try_lock for hs_err EventLog printing [v2]

Thomas Stuefe stuefe at openjdk.java.net
Fri Nov 27 06:23:01 UTC 2020


On Thu, 26 Nov 2020 23:12:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> LGTM
>
>> 
>> 
>> @tstuefe @dholmes-ora What's the path forward with this PR? Have your reconciled and come to a conclusion about what you want me to change?
> 
> I have no particular "wants" in this area I was just trying to evaluate the two proposals. Thomas seems fine with your original proposal now. I thought you were suggesting above you should be using `fatal_error_in_progress()` instead, so I'm not sure if this is your final proposal. If it is then I'm fine with it. There's no perfect solution when it comes to error reporting.
> Thanks.

Yes, I am fine with this. I would have prepared a simpler solution as I originally proposed, but do not want to block this patch.

Thanks, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/1408


More information about the hotspot-dev mailing list