RFR: 8254042: gtest/GTestWrapper.java failed os.test_random [v2]

Mon Nov 30 12:54:16 UTC 2020

On Fri, 27 Nov 2020 00:59:27 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Restore old copyright
>>  - Refix os.random test using Thomas Stuefe's better suggestion.
>
> test/hotspot/gtest/runtime/test_os.cpp line 125:
> 
>> 123:   int num;
>> 124:   for (int k = 0; k < reps; k++) {
>> 125:     num = seed = os::next_random(seed);
> 
> I suggest adding a comment before this line:
> // Use next_random so the calculation is stateless.
> Or something to that affect.

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1422