RFR: 8253717: Relocate stack overflow code out of thread.hpp/cpp [v5]

Coleen Phillimore coleenp at openjdk.java.net
Thu Oct 8 06:57:49 UTC 2020


On Wed, 7 Oct 2020 18:45:14 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/stackOverflow.cpp line 38:
>> 
>>> 36: size_t StackOverflow::_stack_shadow_zone_size = 0;
>>> 37:
>>> 38: void StackOverflow::initialize_stack_zone_sizes(size_t alignment) {
>> 
>> I think you can remove the parameter and hard-code 4K inside this function. The reason is that the "StackXXXPages"
>> parameters are defined as "number of 4k units", not "number of pages".
>
> Ok, I'll move the comment in os.cpp also that tells you why 4k is a thing.

Ok, I made the suggested change and updated the PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/522


More information about the hotspot-dev mailing list