RFR: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method [v2]

Robbin Ehn rehn at openjdk.java.net
Tue Oct 27 07:23:19 UTC 2020


On Tue, 27 Oct 2020 05:42:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>>> You can even do something like:
>>> 
>>> ```
>>>   // Same without DELETE_FUNC.
>>>   template <typename LOOKUP_FUNC>
>>>   bool remove(Thread* thread, LOOKUP_FUNC& lookup_f) {
>>>     struct {
>>>       void operator()(VALUE*) {}
>>>     } ignore_del_f;
>>>     return internal_remove(thread, lookup_f, ignore_del_f);
>>>   }
>>> ```
>>> 
>>> Which I think @kimbarrett hinted.
>> 
>> Something along those lines would be fine too.
>
> Okay, new version then, please take a look!

Still fine!

-------------

PR: https://git.openjdk.java.net/jdk/pull/863


More information about the hotspot-dev mailing list