RFR: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method [v2]

Aleksey Shipilev shade at openjdk.java.net
Tue Oct 27 05:46:29 UTC 2020


On Mon, 26 Oct 2020 22:56:37 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Marked as reviewed by kbarrett (Reviewer).
>
>> You can even do something like:
>> 
>> ```
>>   // Same without DELETE_FUNC.
>>   template <typename LOOKUP_FUNC>
>>   bool remove(Thread* thread, LOOKUP_FUNC& lookup_f) {
>>     struct {
>>       void operator()(VALUE*) {}
>>     } ignore_del_f;
>>     return internal_remove(thread, lookup_f, ignore_del_f);
>>   }
>> ```
>> 
>> Which I think @kimbarrett hinted.
> 
> Something along those lines would be fine too.

Okay, new version then, please take a look!

-------------

PR: https://git.openjdk.java.net/jdk/pull/863


More information about the hotspot-dev mailing list