RFR: 8212107: VMThread issues and cleanup [v2]

[Robbin Ehn]

On Wed, 23 Sep 2020 07:14:59 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since
>> the last revision:
>>  - Merge branch 'master' into 8212107-vmthread
>>  - Fixed nits
>>  - Merge branch 'master' into 8212107-vmthread
>>  - Fixes after review from shipilev.
>>  - Fixed some indent misses
>>  - Fixed ws
>>  - Added assert
>>  - Restructured and simplified
>>  - Removed used linking in VM_Operation
>>  - Removed ticket and use only one Monitor
>>  - ... and 2 more: https://git.openjdk.java.net/jdk/compare/92287620...e49178a4
>
> src/hotspot/share/runtime/vmThread.cpp line 392:
> 
>> 390:   EventMark em("Executing %s VM operation: %s", prev_vm_operation != NULL ? "nested" : "", op->name());
>> 391:
>> 392:   // If we are at a safepoint we will evaluate all the operations that
> 
> "all"? There can only be one surely?

Yes, fixed

> src/hotspot/share/runtime/vmThread.hpp line 74:
> 
>> 72:
>> 73:   void evaluate_operation(VM_Operation* op);
>> 74:   void inner_execute(VM_Operation* op);
> 
> Perhaps nested_execute as it seems this is only for handling the case of a nested vm op?

inner_execute(..) is called in the non nested-case here:
https://github.com/openjdk/jdk/blob/e49178a4445378fa0b5505ad6e9f1661636f88b8/src/hotspot/share/runtime/vmThread.cpp#L474

Nest case:
https://github.com/openjdk/jdk/blob/e49178a4445378fa0b5505ad6e9f1661636f88b8/src/hotspot/share/runtime/vmThread.cpp#L511

-------------

PR: https://git.openjdk.java.net/jdk/pull/228