RFR: 8212107: VMThread issues and cleanup [v2]

[David Holmes]

On Wed, 23 Sep 2020 08:33:23 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/share/runtime/vmThread.hpp line 74:
>> 
>>> 72:
>>> 73:   void evaluate_operation(VM_Operation* op);
>>> 74:   void inner_execute(VM_Operation* op);
>> 
>> Perhaps nested_execute as it seems this is only for handling the case of a nested vm op?
>
> inner_execute(..) is called in the non nested-case here:
> https://github.com/openjdk/jdk/blob/e49178a4445378fa0b5505ad6e9f1661636f88b8/src/hotspot/share/runtime/vmThread.cpp#L474
> 
> Nested case:
> https://github.com/openjdk/jdk/blob/e49178a4445378fa0b5505ad6e9f1661636f88b8/src/hotspot/share/runtime/vmThread.cpp#L511

Sorry I missed that. Seems odd that inner_execute handles nesting when that is only possible via one of the paths by
which it is called - that's why I thought it was only for the case where called from execute(). I'd rather see the
nesting logic handled as before, exclusively on the code path in which it can occur.

-------------

PR: https://git.openjdk.java.net/jdk/pull/228