RFR: 8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function [v2]
Martin Doerr
mdoerr at openjdk.java.net
Thu Sep 24 13:18:49 UTC 2020
On Thu, 24 Sep 2020 12:16:24 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> That the monitor has already been unlocked, or is a null stacklock monitor has been already checked in the caller, so
>> the code that makes it a JRT_ENTRY_NO_ASYNC is unnecessary.
>> Making it a JRT_LEAF like the compiled method entries makes it safer. We know it can never safepoint and
>> unintentionally install a async exception.
>> Tested with tier1-6.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> 8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function
Please note that complete_monitor_unlocking_C is only called by C2. Other JIT compilers have other functions.
SharedRuntime::monitor_exit_helper is used by all ones. I had another question: Shouldn't the call sites in the
interpreter use call_VM_leaf instead of call_VM?
-------------
PR: https://git.openjdk.java.net/jdk/pull/320
More information about the hotspot-dev
mailing list