RFR: 8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function [v2]

Coleen Phillimore coleenp at openjdk.java.net
Thu Sep 24 14:27:26 UTC 2020


On Thu, 24 Sep 2020 13:15:53 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function
>
> Please note that complete_monitor_unlocking_C is only called by C2. Other JIT compilers have other functions.
> SharedRuntime::monitor_exit_helper is used by all ones. I had another question: Shouldn't the call sites in the
> interpreter use call_VM_leaf instead of call_VM?

@TheRealMDoerr you're right, it should be call_VM_leaf so that popframe and force early return are not executed.
Setting up last_Java_sp is benign but unnecessary.  I should have changed the code in
SharedRuntime::monitor_exit_helper instead.  Thanks for looking at this and your help!

-------------

PR: https://git.openjdk.java.net/jdk/pull/320


More information about the hotspot-dev mailing list