RFR: 8265867: thread.hpp defines some enums but no reference

[David Holmes]

On Mon, 26 Apr 2021 18:54:37 GMT, Xin Liu <xliu at openjdk.org> wrote:

> Deleted 2 useless enums.
> This patch also added const and constexpr for the applicable member functions.

Hi Xin,

Please don't mix together cleanups this way. Getting rid of unused enums is fine, but 99% of the patch relates to const and constexpr. I had trouble finding the enum changes among the rest, and what would otherwise be a short and trivial patch becomes more unweildy and requires a lot more time to review. A separate RFE for those would be better IMO. 

Thanks,
David

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3702