RFR: 8265867: thread.hpp defines some enums but no reference
Xin Liu
xliu at openjdk.java.net
Tue Apr 27 04:42:37 UTC 2021
On Tue, 27 Apr 2021 02:05:08 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Hi Xin,
>
> Please don't mix together cleanups this way. Getting rid of unused enums is fine, but 99% of the patch relates to const and constexpr. I had trouble finding the enum changes among the rest, and what would otherwise be a short and trivial patch becomes more unweildy and requires a lot more time to review. A separate RFE for those would be better IMO.
>
> Thanks,
> David
hi, David,
Thanks. I will create another JBS to track const and constexpr issue.
Sorry, I felt it was too "trivial" if one PR just deletes two enums. I will pay attention to it.
thanks,
--lx
-------------
PR: https://git.openjdk.java.net/jdk/pull/3702
More information about the hotspot-dev
mailing list