RFR: 8265867: thread.hpp defines some enums but no reference

[Thomas Stuefe]

On Mon, 26 Apr 2021 18:54:37 GMT, Xin Liu <xliu at openjdk.org> wrote:

> Deleted 2 useless enums.
> This patch also added const and constexpr for the applicable member functions.

I like this change (both the constness fixes and the removal of enums), but as David said, please make them two changes and give them clear titles.

Wrt to the constexpr, I am not against this since constexpr is to my understanding mostly a safety measure against bitrot, preventing us from accidentally making a constexpr function non-const. But the majority seems not to like that part, so I'd just leave it out for now.

Cheers, Thomas

src/hotspot/share/runtime/thread.hpp line 1077:

> 1075:   // last_Java_sp
> 1076:   bool has_last_Java_frame() const               { return _anchor.has_last_Java_frame(); }
> 1077:   intptr_t* last_Java_sp()   const               { return _anchor.last_Java_sp(); }

Why the whitespace change?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3702