RFR: 8255493: Support for pre-generated java.lang.invoke classes in CDS dynamic archive [v10]

[David Holmes]

On Wed, 28 Apr 2021 19:00:20 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Hi, Please review
>> 
>>   When do dynamic dump, the pre-generated lambda form classes from java.lang.invoke are not stored in dynamic archive. The patch will regenerate the four holder classes, 
>>      "java.lang.invoke.Invokers$Holder",
>>      "java.lang.invoke.DirectMethodHandle$Holder",
>>      "java.lang.invoke.DelegatingMethodHandle$Holder",
>>      "java.lang.invoke.LambdaForm$Holder"
>>   which will include the versions in static archive and new loaded functions all together and stored in dynamic archive. New test case added.
>>   (Minor change to PrintSharedArchiveAtExit, which the index is not consecutive)
>> 
>>   Tests: tier1,tier2,tier3,tier4
>>   
>>   Thanks
>>   Yumin
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Only store four lambda invoker (which will be regenerated in dynamic dump) lines in static archive

src/hotspot/share/cds/lambdaFormInvokers.cpp line 82:

> 80: }
> 81: 
> 82: void LambdaFormInvokers::regenerate_holder_classes() {

If this is no longer a TRAPS function then it should not be using CHECK macro:


objArrayHandle list_lines = oopFactory::new_objArray_handle(vmClasses::String_klass(), len, CHECK);
  for (int i = 0; i < len; i++) {
Handle h_line = java_lang_String::create_from_str(_lambdaform_lines->at(i), CHECK);


If exceptions are not possible just use THREAD and comment why they are not possible. If they are possible then you need to use THREAD and handle them appropriately.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3611