RFR: 8255493: Support for pre-generated java.lang.invoke classes in CDS dynamic archive [v10]

Yumin Qi minqi at openjdk.java.net
Wed Apr 28 20:54:54 UTC 2021


On Wed, 28 Apr 2021 20:37:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Only store four lambda invoker (which will be regenerated in dynamic dump) lines in static archive
>
> src/hotspot/share/cds/lambdaFormInvokers.cpp line 82:
> 
>> 80: }
>> 81: 
>> 82: void LambdaFormInvokers::regenerate_holder_classes() {
> 
> If this is no longer a TRAPS function then it should not be using CHECK macro:
> 
> 
> objArrayHandle list_lines = oopFactory::new_objArray_handle(vmClasses::String_klass(), len, CHECK);
>   for (int i = 0; i < len; i++) {
> Handle h_line = java_lang_String::create_from_str(_lambdaform_lines->at(i), CHECK);
> 
> 
> If exceptions are not possible just use THREAD and comment why they are not possible. If they are possible then you need to use THREAD and handle them appropriately.

I will rework the dynamic dump so it will be like static dump --- handle exceptions after returned. So will remove the all the checks in this file. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3611


More information about the hotspot-dev mailing list