RFR: 8272107: Removal of Unsafe::defineAnonymousClass left a dangling C++ class [v3]

[David Holmes]

On Wed, 11 Aug 2021 19:29:41 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this change to remove the now unused CPSlot class.  Uses of CPSlot have been replaced with Symbol*.  The change was tested by running JCK lang and VM tests, Mach5 tiers 1-2 on Linux, Mac OS, and WIndows and Macn5 tiers 3-5 on Linux x64.
>> 
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add comment for unresolved_string_at_put()

Hi Harold,

Cleanup looks good. A couple of minor items below.

Thanks,
David

src/hotspot/share/memory/iterator.hpp line 347:

> 345:   static Symbol* load_symbol(Symbol** p) {
> 346:     return *p;
> 347:   }

Do we even need load_symbol now?

src/hotspot/share/oops/constantPool.hpp line 323:

> 321: 
> 322:   // Note that release_tag_at_put is not needed here because this is called only when
> 323:   // constructing a ConstantPool in a single thread, with no possibility of concurrent access.

Can we put the comment inside the method please, prior to the `tag_at_put` call.

src/hotspot/share/oops/symbol.hpp line 48:

> 46: // in the SymbolTable bucket (the _literal field in HashtableEntry)
> 47: // that points to the Symbol.  All other stores of a Symbol*
> 48: // to a field of a persistent variable (e.g., the _name filed in

Can you fix the typo here please: filed -> field

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5070