RFR: 8272107: Removal of Unsafe::defineAnonymousClass left a dangling C++ class [v3]

Harold Seigel hseigel at openjdk.java.net
Thu Aug 12 13:54:47 UTC 2021


On Thu, 12 Aug 2021 00:40:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add comment for unresolved_string_at_put()
>
> src/hotspot/share/memory/iterator.hpp line 347:
> 
>> 345:   static Symbol* load_symbol(Symbol** p) {
>> 346:     return *p;
>> 347:   }
> 
> Do we even need load_symbol now?

It's not needed.  I removed it.

> src/hotspot/share/oops/symbol.hpp line 48:
> 
>> 46: // in the SymbolTable bucket (the _literal field in HashtableEntry)
>> 47: // that points to the Symbol.  All other stores of a Symbol*
>> 48: // to a field of a persistent variable (e.g., the _name filed in
> 
> Can you fix the typo here please: filed -> field

done

-------------

PR: https://git.openjdk.java.net/jdk/pull/5070


More information about the hotspot-dev mailing list