RFR: 8267265: Use new IR Test Framework to create tests for C2 IGV transformations

[Christian Hagedorn]

On Tue, 17 Aug 2021 15:36:20 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> test/hotspot/jtreg/TEST.groups line 76:
>> 
>>> 74: hotspot_ir_transformations = \
>>> 75:   ir_transformations
>>> 76: 
>> 
>> It would be better to move IR tests into a folder within `compiler`. These tests will then always be executed together with the other compiler tests. Then you can remove these lines. 
>> 
>> It might be a good idea in general to collect IR tests in a separate folder to have more control over them or run them with stress flags in the future etc. As you are the first one to add any IR tests with the new framework, we have some freedom to do a choice now where to put such IR tests in the future. I might suggest `compiler/ir_framework` as location, also with the option to add subfolders there, but maybe @iignatev can provide some more insights/better suggestions on this topic.
>
> as these tests are c2 tests, they are to be inside `test/hotspot/jtreg/compiler/c2`. I don't think `ir_framework` is a good directory name, as they aren't tests for `ir_framework`, nor `ir_framework` itself,  so I'd suggest `test/hotspot/jtreg/compiler/c2/ir_transformations`, or `test/hotspot/jtreg/compiler/c2/idealization`.
> 
> on a separate note, @JohnTortugo why have you added a dedicated group for these tests?
> 
> -- Igor

Thanks Igor for your input!

> as they aren't tests for `ir_framework`

Right. This might be misleading. 

>  so I'd suggest test/hotspot/jtreg/compiler/c2/ir_transformations, or test/hotspot/jtreg/compiler/c2/idealization.

Could we also choose `test/hotspot/jtreg/compiler/c2/ir_tests` (should we use camel case or underscore?) as top folder for any kinds of IR tests? Then we could still add a subfolder like `ideal_transformations` to it (`test/hotspot/jtreg/compiler/c2/ir_tests/ideal_transformations`). If there are other IR tests later, for example for string opts, we can add a `stringopts` subfolder into the `ir_tests` top folder and so on.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5135