RFR: 8267265: Use new IR Test Framework to create tests for C2 IGV transformations

[Igor Ignatyev]

On Tue, 17 Aug 2021 15:52:50 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> as these tests are c2 tests, they are to be inside `test/hotspot/jtreg/compiler/c2`. I don't think `ir_framework` is a good directory name, as they aren't tests for `ir_framework`, nor `ir_framework` itself,  so I'd suggest `test/hotspot/jtreg/compiler/c2/ir_transformations`, or `test/hotspot/jtreg/compiler/c2/idealization`.
>> 
>> on a separate note, @JohnTortugo why have you added a dedicated group for these tests?
>> 
>> -- Igor
>
> Thanks Igor for your input!
> 
>> as they aren't tests for `ir_framework`
> 
> Right. This might be misleading. 
> 
>>  so I'd suggest test/hotspot/jtreg/compiler/c2/ir_transformations, or test/hotspot/jtreg/compiler/c2/idealization.
> 
> Could we also choose `test/hotspot/jtreg/compiler/c2/ir_tests` (should we use camel case or underscore?) as top folder for any kinds of IR tests? Then we could still add a subfolder like `ideal_transformations` to it (`test/hotspot/jtreg/compiler/c2/ir_tests/ideal_transformations`). If there are other IR tests later, for example for string opts, we can add a `stringopts` subfolder into the `ir_tests` top folder and so on.

> Could we also choose `test/hotspot/jtreg/compiler/c2/ir_tests` as top folder for any kinds of IR tests? 

sounds good to me. 

> should we use camel case or underscore?

given it's java code, and the directory names are part of a package name, we should use lowerCamelCase.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5135