RFR: 8267265: Use new IR Test Framework to create tests for C2 IGV transformations

[Vladimir Kozlov]

On Tue, 17 Aug 2021 15:59:05 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Thanks Igor for your input!
>> 
>>> as they aren't tests for `ir_framework`
>> 
>> Right. This might be misleading. 
>> 
>>>  so I'd suggest test/hotspot/jtreg/compiler/c2/ir_transformations, or test/hotspot/jtreg/compiler/c2/idealization.
>> 
>> Could we also choose `test/hotspot/jtreg/compiler/c2/ir_tests` (should we use camel case or underscore?) as top folder for any kinds of IR tests? Then we could still add a subfolder like `ideal_transformations` to it (`test/hotspot/jtreg/compiler/c2/ir_tests/ideal_transformations`). If there are other IR tests later, for example for string opts, we can add a `stringopts` subfolder into the `ir_tests` top folder and so on.
>
>> Could we also choose `test/hotspot/jtreg/compiler/c2/ir_tests` as top folder for any kinds of IR tests? 
> 
> sounds good to me. 
> 
>> should we use camel case or underscore?
> 
> given it's java code, and the directory names are part of a package name, we should use lowerCamelCase.

I am **against** moving tests under `/c2` directory. This directory was created to split original set of tests to run in parallel and not related to C2 compiler. I want to have directories in `/compiler` per optimization/transformation type as we have now. For example, `/loopopts` is for C2 only but it is not under `/c2`.

Actually I want to clear `c2` and `c1` directories eventually to move tests to corresponding category directories instead.

So I am for `/compiler/irTests`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5135