RFR: 8272797: Mutex with rank safepoint_check_never imply allow_vm_block [v4]

Coleen Phillimore coleenp at openjdk.java.net
Thu Aug 26 17:38:28 UTC 2021


On Thu, 26 Aug 2021 06:01:48 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove allow_vm_block parameter if safepoint_check_never.
>
> Hi Coleen,
> 
> I've put a lengthy comment in the JBS issue explaining how I see this change, but the bottom like is that I think it is a perfectly fine simplification.
> 
> Thanks,
> David

Thanks for the comment in the bug and review, David, and for the review Patricio.  @dholmes-ora I added another change that I'd like you to look at.  I didn't change the order of arguments in mutexLocker.cpp because I'm going to save that bit of review tedium for the bigger task of renaming the ranks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5218


More information about the hotspot-dev mailing list