RFR: 8277372: Add getters for BOT and card table members [v4]
Stefan Johansson
sjohanss at openjdk.java.net
Wed Dec 1 15:14:24 UTC 2021
On Tue, 30 Nov 2021 13:39:41 GMT, Vishal Chand <duke at openjdk.java.net> wrote:
>> Changed the visibility, added getters and refactored the following:
>>
>> 1. Card Table Members
>> 2. BOT members
>> 3. ObjectStartArray block members
>
> Vishal Chand has updated the pull request incrementally with one additional commit since the last revision:
>
> Rename BOTConstants
Nice to see this unified. Some comments below.
src/hotspot/share/gc/shared/blockOffsetTable.hpp line 55:
> 53: static uint _log_bot_card_size_words;
> 54: static uint _bot_card_size_bytes;
> 55: static uint _bot_card_size_words;
Maybe change `words` to `in_words` to better match other places where we have sizes in words. And as Thomas suggested above, maybe also drop the `bot` in/pre-fix.
And also change the getters below.
-------------
Changes requested by sjohanss (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6570
More information about the hotspot-dev
mailing list