RFR: 8277372: Add getters for BOT and card table members [v4]

Stefan Johansson sjohanss at openjdk.java.net
Wed Dec 1 15:14:24 UTC 2021


On Wed, 1 Dec 2021 12:06:29 GMT, Vishal Chand <duke at openjdk.java.net> wrote:

>> Okay, `_osa_card_shift` and so on is also acceptable to me, but just `_card_shift`/`_card_size` would be fine too. We typically do not prefix members with abbreviations of class name they are in; I see now that we have that `_bot` prefix in the other class, for me the `bot` prefix not necessarily refers to the class  but to the concept of a block offset table.
>> 
>> Maybe just reduce the names in both cases to `_card_size`/`_card_shift`/`_log_card_<something>`? What do others think?
>
> You mean for both blockOffsetTable and objectStartArray, all the relevant members be renamed to _card_size and so on?

I think this sounds like a good plan.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6570


More information about the hotspot-dev mailing list