RFR: 8260019: Move some Thread subtypes out of thread.hpp

Coleen Phillimore coleenp at openjdk.java.net
Thu Feb 4 13:52:43 UTC 2021


On Thu, 4 Feb 2021 06:19:21 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> thread.hpp is 2133 lines long and is included by about 800 out of 1000 HotSpot .o files. It also pulls in many other header files.
>> 
>> Many of the Thread subtypes are infrequently used. This RFE move the easy ones to compilerThread.hpp and nonJavaThread.hpp. This reduces thread.hpp to 1888 lines.
>> 
>> (I hope to do more refactoring of thread.hpp in future RFEs).
>> 
>> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.
>
> src/hotspot/share/compiler/compilerThread.hpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved.
> 
> Should a new file only have a single copyright year? I'm not sure what the rule is about splitting existing files but you use a single year in the new cpp files.

I think the rule has been: if it's a new file, it gets a new year.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2390


More information about the hotspot-dev mailing list