RFR: JDK-8260372: [PPC64] Add support for JDK-8210498 and JDK-8222841 [v2]
Martin Doerr
mdoerr at openjdk.java.net
Mon Feb 8 11:26:44 UTC 2021
On Sun, 7 Feb 2021 22:02:04 GMT, Niklas Radomski <github.com+9200663+Quaffel at openjdk.org> wrote:
>> Introduces support for _nmethod entry barriers_ and _c2i entry barriers_ on the ppc platform. Those are required to enable concurrent class unloading for compatible garbage collectors, such as Shenandoah or zGC.
>>
>> _This is a preparational change for the Shenandoah GC port to ppc. As such, it introduces features that the current version doesn't make use of, but that are required for the upcoming change. This way, the scope of the upcoming change is limited to Shenandoah-specific functionality; making its review a little easier._
>
> Niklas Radomski has updated the pull request incrementally with one additional commit since the last revision:
>
> Apply Martin's feedback
Thanks for the update. I found an additional Big Endian bug (missing function descriptor).
src/hotspot/cpu/ppc/stubGenerator_ppc.cpp line 3556:
> 3554: StubCodeMark mark(this, "StubRoutines", "nmethod_entry_barrier");
> 3555:
> 3556: address stub_address = __ pc();
Please use __ function_entry(); instead of __ pc();
Otherwise it's broken on Big Endian which use ABI v1.
-------------
Changes requested by mdoerr (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2432
More information about the hotspot-dev
mailing list