RFR: JDK-8260372: [PPC64] Add support for JDK-8210498 and JDK-8222841 [v2]
Martin Doerr
mdoerr at openjdk.java.net
Mon Feb 8 11:31:47 UTC 2021
On Mon, 8 Feb 2021 11:23:03 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Niklas Radomski has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Apply Martin's feedback
>
> src/hotspot/cpu/ppc/stubGenerator_ppc.cpp line 3556:
>
>> 3554: StubCodeMark mark(this, "StubRoutines", "nmethod_entry_barrier");
>> 3555:
>> 3556: address stub_address = __ pc();
>
> Please use __ function_entry(); instead of __ pc();
> Otherwise it's broken on Big Endian which use ABI v1.
Sorry, __ pc() seems to be correct. It's directly called from nmethod_entry_barrier without using a function descriptor.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2432
More information about the hotspot-dev
mailing list