RFR: 8261608: Move common CDS archive building code to archiveBuilder.cpp [v2]

[Ioi Lam]

On Fri, 12 Feb 2021 00:46:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fixed spaces
>>  - use member initializer list; clean up log message
>
> src/hotspot/share/memory/metaspaceShared.inline.hpp line 34:
> 
>> 32: 
>> 33: #if INCLUDE_CDS_JAVA_HEAP
>> 34: bool MetaspaceShared::is_archive_object(oop p) {
> 
> Was this unused? I don't find 'is_archive_object' in the diff.

This whole file was unused (and the function was not even declared in the MetaspaceShared class) so I removed it.

> src/hotspot/share/memory/archiveBuilder.cpp line 178:
> 
>> 176:   _num_instance_klasses = 0;
>> 177:   _num_obj_array_klasses = 0;
>> 178:   _num_type_array_klasses = 0;
> 
> Should these be initializers also?

I changed them to initializers.

> src/hotspot/share/classfile/moduleEntry.cpp line 33:
> 
>> 31: #include "logging/log.hpp"
>> 32: #include "memory/archiveBuilder.hpp"
>> 33: #include "memory/archiveUtils.hpp"
> 
> Do these files need archiveUtils.hpp or does archiveBuilder.hpp need it?

Both packageEntry.cpp and moduleEntry.cpp use ArchivePtrMarker which is defined in archiveUtils.hpp.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2536