RFR: 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set [v4]

Xin Liu xliu at openjdk.java.net
Sun Feb 14 05:44:51 UTC 2021


> Add a flag _suppress_cr to outputStream. outstream objects won't emit any CR if it's set.
> Correct TypeInstPtr::dump2 to make sure it only emits klass name once.
> Remove the comment because Klass::oop_print_on() has emitted the address of oop.
> 
> Before:
> 689  ConP  ===  0  [[ 821 ]]   Oop:java/lang/Stringjava.lang.String
> {0x000000010159d7c8} - klass: public final synchronized 'java/lang/String'
> - string: "a"
> :Constant:exact *
> 
> After:
> 689  ConP  ===  0  [[ 821 ]]   Oop:java.lang.String {0x000000010159d7c8} - klass: public final synchronized 'java/lang/String' - string: "a":Constant:exact *

Xin Liu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set
   
   reimplement this feature. withdraw my intrusive change in outputStream.
   use stringStream only for the constant OopPtr. after oop->print_on(st),
   delete all appearances of '\n'
 - Merge branch 'master' into JDK-8260198
 - 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set
   
   fix merge conflict.
 - Merge branch 'master' into JDK-8260198
 - 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set
   
   Add a flag _suppress_cr to outputStream. outstream objects won't emit any CR if it's set.
   Correct TypeInstPtr::dump2 to make sure it only emits klass name once.
   Remove the comment because Klass::oop_print_on() has emitted the address of oop.
   
   Before:
   689  ConP  ===  0  [[ 821 ]]   Oop:java/lang/Stringjava.lang.String
   {0x000000010159d7c8} - klass: public final synchronized 'java/lang/String'
    - string: "a"
    :Constant:exact *
   
   After:
   689  ConP  ===  0  [[ 821 ]]   Oop:java.lang.String {0x000000010159d7c8} - klass: public final synchronized 'java/lang/String' - string: "a":Constant:exact *

-------------

Changes: https://git.openjdk.java.net/jdk/pull/2178/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2178&range=03
  Stats: 51 lines in 4 files changed: 45 ins; 1 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2178.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2178/head:pull/2178

PR: https://git.openjdk.java.net/jdk/pull/2178


More information about the hotspot-dev mailing list