RFR: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest

[Igor Ignatyev]

On Fri, 5 Feb 2021 20:35:23 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

> This is a preliminary review. I would like to get the initial feedback before I proceed with conversion of the remaining tests.
> 
> Here is what I did so far:
>   - created a UnitTestThread and a main test runner, based on gtests with similar needs
>   - moved the original code from HotSpot internals (so called hotspot internal tests: src/hotspot/share/memory/virtualspace.cpp)
>     to the newly created gtest while wrapping it into a TestReservedSpace class. I did not change the code of the test.
>   - removed invocations from whitebox.cpp
> 
> Testing:
>   - ran GTestWrapper on usual platforms - All PASS
>   - ensured that ReservedSpaceConcurrent is in the logs and passed
> 
> After gathering the feedback my plan is:
> Plan:
>   - move the remaining internal Memory/VirtualSpace tests into a gTest
>     - I am thinking about using separate files for each test
>   - create a common file for UnitTestThread and MultiThreadTestRunner to reuse the code

Changes requested by iignatyev (Reviewer).

test/hotspot/gtest/runtime/test_os_windows.cpp line 704:

> 702: 
> 703: TEST_VM(os_windows, reserve_memory_special_concurrent) {
> 704:   ConcurrentTestRunner testRunner(new ReserveMemorySpecialRunnable(), 30, 15000);

a memory leak

test/hotspot/gtest/runtime/test_os_linux.cpp line 417:

> 415: 
> 416: TEST_VM(os_linux, reserve_memory_special_concurrent) {
> 417:   ConcurrentTestRunner testRunner(new ReserveMemorySpecialRunnable(), 30, 15000);

yet another memory leak

test/hotspot/gtest/memory/test_virtualspace.cpp line 676:

> 674: 
> 675: TEST_VM(VirtualSpace, virtual_space_concurrent) {
> 676:   ConcurrentTestRunner testRunner(new VirtualSpaceRunnable(), 30, 15000);

one more memory leak

test/hotspot/gtest/memory/test_virtualspace.cpp line 664:

> 662: 
> 663: TEST_VM(VirtualSpace, reserve_space_concurrent) {
> 664:   ConcurrentTestRunner testRunner(new ReservedSpaceRunnable(), 30, 15000);

and a memory leak again

-------------

PR: https://git.openjdk.java.net/jdk/pull/2436