RFR: 8261608: Move common CDS archive building code to archiveBuilder.cpp [v4]
Ioi Lam
iklam at openjdk.java.net
Mon Feb 15 06:40:58 UTC 2021
> This is a follow-up to https://git.openjdk.java.net/jdk/pull/2296:
>
> - Move common code for writing the CDS archive from metaspaceShared.cpp to archiveBuilder.cpp
>
> - Data structures related to dumping were haphazardly organized in several classes (e.g., `DumpRegions`). We needed various APIs to access them across classes. These should be consolidated in archiveBuilder.cpp and the API should be cleaned up
>
> - Detailed stats (`DumpAllocStats::print_stats`) were available only for static dump. Refactor the code so they are also printed for dynamic dump
Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Merge branch 'master' into 8261608-move-common-archive-building-code
- review comments by @calvinccheung
- fixed spaces
- use member initializer list; clean up log message
- 8261608: Move common CDS archive building code to archiveBuilder.cpp
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2536/files
- new: https://git.openjdk.java.net/jdk/pull/2536/files/54e7185f..8aaf33f6
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2536&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2536&range=02-03
Stats: 4934 lines in 207 files changed: 2805 ins; 891 del; 1238 mod
Patch: https://git.openjdk.java.net/jdk/pull/2536.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2536/head:pull/2536
PR: https://git.openjdk.java.net/jdk/pull/2536
More information about the hotspot-dev
mailing list