RFR: 8256417: Exclude TestJFRWithJMX test from running with PodMan

Mikhailo Seledtsov mseledtsov at openjdk.java.net
Thu Feb 25 20:52:41 UTC 2021


On Thu, 25 Feb 2021 20:04:20 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

>> Hi Misha,
>> 
>> so this test can't be run w/ `podman` only if the test-user doesn't have root-level privileges? if so, I think it's better to check if we really don't have such priviliges and throw `SkippedException` (e.g. the same way we do in `SATestUtils` via `Platform.isRoot`). that way, the test will still be runnable in some configurations.
>> 
>> -- Igor
>
> Igor, thanks for the suggestion. I will update the code to use SkippedException and Platform.isRoot

Igor, while following your suggestion of using jtreg.SkippedException, I am thinking about keeping the new VMProps.containerEngine() in the VMProps.java. It can come in handy in the future. I hope you do not mind that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2726


More information about the hotspot-dev mailing list