RFR: 8259374: Make ThreadInVMfromNative have ResetNoHandleMark
Daniel D.Daugherty
dcubed at openjdk.java.net
Thu Jan 7 21:12:58 UTC 2021
On Thu, 7 Jan 2021 18:28:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> Please review this straightforward change to add a ResetNoHandleMark in the ThreadInVMfromNative transition class so that callers don't have to do this. Tested with tier1-3.
> This was broken out of a larger change for JDK-8258032 Reconsider LEAF entry restrictions.
Extracting this from JDK-8258032 makes the changes very clear.
Thumbs up!
Just for the record, these changes were included in testing done for JDK-8258032
so have gone through Mach5 Tier[1-6] if I remember correctly...
src/hotspot/share/runtime/handles.hpp line 292:
> 290:
> 291: // ResetNoHandleMark is called in a context where there is an enclosing
> 292: // NoHandleMark. Thread in _thread_in_native must not create handles so
nit grammar: s/Thread in/A thread in/
-------------
Marked as reviewed by dcubed (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1983
More information about the hotspot-dev
mailing list