RFR: 8259374: Make ThreadInVMfromNative have ResetNoHandleMark [v2]

Coleen Phillimore coleenp at openjdk.java.net
Thu Jan 7 22:21:08 UTC 2021


On Thu, 7 Jan 2021 21:09:46 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix grammar
>
> Extracting this from JDK-8258032 makes the changes very clear.
> Thumbs up!
> 
> Just for the record, these changes were included in testing done for JDK-8258032
> so have gone through Mach5 Tier[1-6] if I remember correctly...

Yes, I tested tiers 1-6 on the greater change containing this one, and retested tiers 1-3.

> src/hotspot/share/runtime/handles.hpp line 292:
> 
>> 290: 
>> 291: // ResetNoHandleMark is called in a context where there is an enclosing
>> 292: // NoHandleMark.  Thread in _thread_in_native must not create handles so
> 
> nit grammar: s/Thread in/A thread in/

fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1983


More information about the hotspot-dev mailing list