RFR: 8259713: Fix comments and ResetNoHandleMark in deoptimization

Coleen Phillimore coleenp at openjdk.java.net
Wed Jan 13 22:49:04 UTC 2021


On Wed, 13 Jan 2021 22:21:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/deoptimization.cpp line 692:
>> 
>>> 690:   // Beware though because allocating Handles must have a HandleMark or else the
>>> 691:   // Handles will be leaked.
>>> 692:   ResetNoHandleMark rnhm;
>> 
>> So I'm confused. The bug description says:
>> 
>>> the ResetNoHandleMark is unneeded
>> 
>> but it is still here.
>
> This one is needed because it's in a JRT_LEAF.  The one above in the JRT_BLOCK_ENTRY is unneeded (along with the comment that matched the one in this unpack_frames() function.)

Correction, I didn't remove a ResetNoHandleMark in fetch_unroll_info, because there wasn't one there.  It was removed already.  I just removed the comment that described the code that isn't there anymore.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2069


More information about the hotspot-dev mailing list