RFR: 8259713: Fix comments and ResetNoHandleMark in deoptimization
Daniel D.Daugherty
dcubed at openjdk.java.net
Thu Jan 14 01:34:04 UTC 2021
On Wed, 13 Jan 2021 21:12:34 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> This is a small part of the withdrawn change for https://github.com/openjdk/jdk/pull/1990 to fix the out-of-date comments in deoptimization.cpp.
> Tested with tier1-3.
src/hotspot/share/runtime/deoptimization.cpp line 693:
> 691: // Handles will be leaked.
> 692: ResetNoHandleMark rnhm;
> 693: HandleMark hm(thread);
Here's a simpler rewrite for L687 -> L693:
// This code wants to allocate handles which is okay in a leaf method,
// but JRT_LEAF contains a NoHandleMark so we have to work around
// that with ResetNoHandleMark in order to create a HandleMark here:
ResetNoHandleMark rnhm;
HandleMark hm(thread);
-------------
PR: https://git.openjdk.java.net/jdk/pull/2069
More information about the hotspot-dev
mailing list