RFR: 8259713: Fix comments and ResetNoHandleMark in deoptimization

Daniel D.Daugherty dcubed at openjdk.java.net
Thu Jan 14 01:34:02 UTC 2021


On Wed, 13 Jan 2021 22:42:07 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Changes requested by dcubed (Reviewer).
>
> The comment in the bug says this:
> 
>> The comments are wrong and the ResetNoHandleMark is unneeded
>> since Deoptimization::fetch_unroll_info is a JRT_BLOCK_ENTRY (has a HandleMarkCleaner). 
> 
> so I read this as you are changing Deoptimization::fetch_unroll_info to:
> 
> - fix a comment
> - remove a ResetNoHandleMark
> 
> The comment in the bug doesn't mention JRT_LEAF at all, but you're
> making comment changes there also.
> 
> No where in this fix do I see a ResetNoHandleMark being removed.
> 
> Is the reason for my confusion more clear yet?

Please fix the bug synopsis and make the PR description match.
Please correct the bug description to describe what you are doing.
I also added a proposed comment rewrite for you.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2069


More information about the hotspot-dev mailing list