RFR: 8260025: HotSpot cannot identify Zen (family 17h) processor

[Yasumasa Suenaga]

On Wed, 20 Jan 2021 08:15:37 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> Hi Yasumasa,
>> 
>> You should have led with the fact this is caused by a missing comma! IIUC this will shorten the array by one entry and so Zen will be in the wrong position.
>> 
>> Looks good and trivial.
>> 
>> Thanks,
>> David
>
> Thanks @dholmes-ora and @tstuefe for the review!
> 
>> You should have led with the fact this is caused by a missing comma!
> 
> Do you mean we should change the subject like "Missing comma in VM_Version_Ext::_family_id_amd"?
> 
>> IIUC this will shorten the array by one entry and so Zen will be in the wrong position.
> 
> Yes, "Zen" was located at penultimate position, and NULL was set to the tail when I checked it on GDB.

> > Do you mean we should change the subject like "Missing comma in VM_Version_Ext::_family_id_amd"?
> 
> Well yes, the bug report could have been clearer :) I went from the bug
> report to the PR link and straight to "Files changed" to do the review -
> after checking that we did in fact have Zen support. So I never saw the
> "It is caused by missing comma ..." you added for the PR description.

Sorry for the confusing subject.
Ok, I will change the subject both JBS and this PR before pushing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2158