RFR: 8270179: Rename Amalloc_4 [v4]

[Coleen Phillimore]

On Mon, 12 Jul 2021 13:52:08 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/memory/arena.hpp line 105:
>> 
>>> 103:   debug_only(void* malloc(size_t size);)
>>> 104: 
>>> 105:   void* internal_malloc_words(size_t x, AllocFailType alloc_failmode = AllocFailStrategy::EXIT_OOM)  {
>> 
>> If UseMallocOnly is retained, I think a better name for this would be internal_amalloc_only, to avoid confusion with the case of actually using malloc.  (And yes, this can be taken as another argument for nuking that option.)
>
> Ok.  I'll file another RFE for removing UseMallocOnly.

I decided that UseMallocOnly found an interesting bug once and there's a test for it, so it might find another interesting bug someday, so I added a comment and decided to leave it.  We can decide some other time to remove it if we have a good alternative.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4750