RFR: 8264543: Cross modify fence optimization for x86 [v2]

David Holmes dholmes at openjdk.java.net
Thu Jul 15 07:56:12 UTC 2021


On Thu, 15 Jul 2021 07:24:04 GMT, Xubo Zhang <github.com+58006833+xbzhang99 at openjdk.org> wrote:

>> src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp line 461:
>> 
>>> 459: }
>>> 460: 
>>> 461: bool os::supports_serialize(){
>> 
>> This function is unnecessary and pollutes the OS namespace with something that is not OS related. Just use VM_Version::supports_serialize() directly.
>
> orderAccess_linux_x86.hpp is included in orderAccess.hpp, atomic.hpp, etc. VM_Version is not defined in any of the nested header files. If I add inclusion of vm_version.hpp in any of these nested head filer,  it will be messy.
> Not sure about the best solution here.

What actually happens if you just include vm_version.hpp in orderAccess_linux_x86.hpp ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3334


More information about the hotspot-dev mailing list