RFR: 8264543: Cross modify fence optimization for x86 [v2]
Xubo Zhang
github.com+58006833+xbzhang99 at openjdk.java.net
Thu Jul 15 18:15:15 UTC 2021
On Thu, 15 Jul 2021 07:53:28 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> orderAccess_linux_x86.hpp is included in orderAccess.hpp, atomic.hpp, etc. VM_Version is not defined in any of the nested header files. If I add inclusion of vm_version.hpp in any of these nested head filer, it will be messy.
>> Not sure about the best solution here.
>
> What actually happens if you just include vm_version.hpp in orderAccess_linux_x86.hpp ?
it will give me errors, like 'Atomic' has not been declared.
Also, the cross_modify_fence_impl actually is os-dependent. Linux and Windows have different implementations.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3334
More information about the hotspot-dev
mailing list