RFR: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest [v6]
Igor Ignatyev
iignatyev at openjdk.java.net
Wed Mar 3 16:08:45 UTC 2021
On Fri, 26 Feb 2021 03:45:07 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:
>> test/hotspot/gtest/concurrentTestRunner.inline.hpp line 1:
>>
>>> 1: /*
>>
>> for c++, we don't use camelCase in filenames, but rather use small_snake_case
>
> OK. I saw gtestMain.cpp, gtestLauncher.cpp and a few others, and just followed that. I also see a number of test_camelCase.cpp: test_primitiveConversions.cpp, test_logSelectionList.cpp and so on. In fact, it seems the most prevalent pattern for gtests is test_camelCase.cpp.
>
> Anyway, no problem, I can rename this file to concurrent_test_runner.inline.hpp
apparently, I had a false memory, we indeed have more `camelCase` than `small_snake_case` files, so @mseledts, you will need to revert that. sorry for wasting your time. in my defense, most of the files are just `case` hence can be interpreted either way :)
-------------
PR: https://git.openjdk.java.net/jdk/pull/2436
More information about the hotspot-dev
mailing list