RFR: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest [v6]
Kim Barrett
kbarrett at openjdk.java.net
Wed Mar 3 14:48:46 UTC 2021
On Fri, 26 Feb 2021 03:45:07 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:
>> test/hotspot/gtest/concurrentTestRunner.inline.hpp line 1:
>>
>>> 1: /*
>>
>> for c++, we don't use camelCase in filenames, but rather use small_snake_case
>
> OK. I saw gtestMain.cpp, gtestLauncher.cpp and a few others, and just followed that. I also see a number of test_camelCase.cpp: test_primitiveConversions.cpp, test_logSelectionList.cpp and so on. In fact, it seems the most prevalent pattern for gtests is test_camelCase.cpp.
>
> Anyway, no problem, I can rename this file to concurrent_test_runner.inline.hpp
This statement that we use small_snake_case for filenames is mostly wrong. Most HotSpot files contain some primary class, whose name is CamelCased, and the associated files are camelCased. There are a fairly small number of exceptions to that. There are some suffixes and prefixes that get added on, such as cpu and os suffixes (`_linux`, `_windows`, &etc, suffixes, `test_` gtest prefix, component prefixes like `c1_` and `gc_`), but those are mostly add-ons to the basic camelCase convention.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2436
More information about the hotspot-dev
mailing list