RFR: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest [v9]

Mikhailo Seledtsov mseledtsov at openjdk.java.net
Thu Mar 4 20:18:44 UTC 2021


On Thu, 4 Mar 2021 07:48:11 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Mikhailo Seledtsov has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Adding os_ prefix to concurrent virtual space tests
>>  - Using os:malloc instead of std::vector
>
> Hi Misha,
> 
> two small remarks. As I wrote yesterday, I think this is a good cleanup despite my doubts. 
> 
> I don't see any GAs running. Can you enable them please? Under "Checks" we should see that all platforms build; also, since the gtests are part of tier1, they run too and we see that they work in all configurations. (eg like this: https://github.com/openjdk/jdk/pull/2751/checks)
> 
> You may have to enable github actions if you have never done so and this is your first work in your personal jdk fork (see "Actions" tab under your repo).
> 
> Cheers, Thomas

Thomas,

Thank you again for reviewing this change.
  - I will figure out and enable GitHub actions
  - will update allocation/free to use NEW_C_HEAP_ARRAY/FREE_C_HEAP_ARRAY from memory/allocation.hpp
  - #endif // GTEST_CONCURRENT_TEST_RUNNER_INLINE_HPP
  - will run internal testing, including available builds, tier1 and gtests on all usual platforms
  - if I do not receive additional feedback, my plan is to integrate on Monday

Thanks,
Misha

-------------

PR: https://git.openjdk.java.net/jdk/pull/2436


More information about the hotspot-dev mailing list