RFR: 8213177: GlobalCounter::CSContext could be an enum class

[Lois Foltan]

On Tue, 9 Mar 2021 16:04:19 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this small change for JDK-8213177.  The change was regression tested with Mach5 tiers 1 and 2 on Linux, Windows, and Mac OS, and Mach5 tiers 3-5 on Linux x64.
> 
> Thanks, Harold

Looks good Harold!  I just have a couple of minor comments.

Lois

src/hotspot/share/utilities/globalCounter.hpp line 68:

> 66:  public:
> 67: 
> 68: 

extra additional line

src/hotspot/share/utilities/globalCounter.hpp line 72:

> 70:   // critical_section_begin() to critical_section_end().
> 71:   enum class CSContext : uintx {}; // [COUNTER_ACTIVE, COUNTER_INCREMENT)
> 72: 

Please change the [ in the comment to a (

src/hotspot/share/utilities/globalCounter.hpp line 74:

> 72: 
> 73:   // Give these access to the private COUNTER_* constants.
> 74:   friend struct EnumeratorRange<CSContext>;

By "these" do you mean the GlobalCounter class?

-------------

Marked as reviewed by lfoltan (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2895