RFR: 8213177: GlobalCounter::CSContext could be an enum class [v2]

[Harold Seigel]

On Wed, 10 Mar 2021 17:50:08 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comments
>
> src/hotspot/share/utilities/globalCounter.hpp line 72:
> 
>> 70:   // critical_section_begin() to critical_section_end().
>> 71:   enum class CSContext : uintx {}; // [COUNTER_ACTIVE, COUNTER_INCREMENT)
>> 72: 
> 
> Please change the [ in the comment to a (

Fixed

> src/hotspot/share/utilities/globalCounter.hpp line 74:
> 
>> 72: 
>> 73:   // Give these access to the private COUNTER_* constants.
>> 74:   friend struct EnumeratorRange<CSContext>;
> 
> By "these" do you mean the GlobalCounter class?

Changed from 'these' to 'this'.  This gives access needed during expansion of the ENUMERATOR_VALUE_RANGE macro below.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2895